Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-22555 Fix infinity loop in RuleBasedCollator constructor #2677

Merged
merged 1 commit into from
Nov 29, 2023
Merged

ICU-22555 Fix infinity loop in RuleBasedCollator constructor #2677

merged 1 commit into from
Nov 29, 2023

Conversation

FrankYFTang
Copy link
Contributor

@FrankYFTang FrankYFTang commented Oct 24, 2023 •
edited
Loading

Fix C++ and Java code.
Add unit tests for both C++ and Java.

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22555
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@FrankYFTang FrankYFTang requested a review from markusicu October 24, 2023 22:41
@markusicu markusicu self-assigned this Oct 26, 2023
@FrankYFTang
ICU-22555 Fix infinity loop in RuleBasedCollator constructor
faf44de 
Fix C++ and Java code.
Add unit tests for both C++ and Java.
@FrankYFTang FrankYFTang force-pushed the ICU-22555-infinity-permute branch from 5907cd4 to faf44de Compare October 31, 2023 19:52
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4j/main/core/src/main/java/com/ibm/icu/text/CanonicalIterator.java is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@FrankYFTang
Copy link
Contributor Author

@markusicu friendly ping

@FrankYFTang
Copy link
Contributor Author

Friendly ping. This bug was reported on 2023-10-20 and the fix is ready for review since 2023-10-31

richgillam
richgillam approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@richgillam richgillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FrankYFTang FrankYFTang merged commit 757d2cd into unicode-org:main Nov 29, 2023
97 checks passed
@FrankYFTang FrankYFTang deleted the ICU-22555-infinity-permute branch November 29, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richgillam richgillam richgillam approved these changes

@markusicu markusicu Awaiting requested review from markusicu

Assignees

@markusicu markusicu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FrankYFTang @richgillam @markusicu