Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-22392 Add, primary support for Haiku #2463

Merged
merged 1 commit into from
Sep 24, 2024
Merged

ICU-22392 Add, primary support for Haiku #2463

merged 1 commit into from
Sep 24, 2024

Conversation

Begasus
Copy link
Contributor

@Begasus Begasus commented May 14, 2023 •
edited by markusicu
Loading

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22392
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@CLAassistant
Copy link

CLAassistant commented May 14, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Begasus Begasus mentioned this pull request May 14, 2023
Merged
@markusicu markusicu self-assigned this May 18, 2023
@markusicu markusicu requested a review from srl295 May 18, 2023 16:57
srl295
srl295 previously approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok one question though.

icu4c/source/common/putilimp.h Outdated Show resolved Hide resolved
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/common/putilimp.h is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/common/putilimp.h is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@Begasus
Copy link
Contributor Author

Begasus commented Apr 29, 2024

Saw this was still open anything left to do?

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/common/putilimp.h is different
  • icu4c/source/configure.ac is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

markusicu
markusicu previously approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we dropped the ball here. Changes look harmless.
I just rebased on current main to pick up newer CI checks.

@markusicu markusicu added the incomplete Needs work; do not approve/merge as is. label Sep 23, 2024
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/common/putilimp.h is different
  • icu4c/source/common/unicode/platform.h is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@markusicu markusicu removed the incomplete Needs work; do not approve/merge as is. label Sep 24, 2024
echeran
echeran approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@echeran echeran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markusicu markusicu merged commit ce11068 into unicode-org:main Sep 24, 2024
94 checks passed
@roubert
Copy link
Member

roubert commented Sep 24, 2024

I've now sent PR #3212 for review to regenerate configure after configure.ac was updated by this PR.

@Begasus
Copy link
Contributor Author

Begasus commented Sep 25, 2024 •
edited
Loading

Thanks!

EDIT: packaged latest commit checkout and a build for boost, so far all good. :D

@Begasus Begasus deleted the haiku branch September 25, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusicu markusicu markusicu approved these changes

@mtl1979 mtl1979 mtl1979 left review comments

@echeran echeran echeran approved these changes

@srl295 srl295 Awaiting requested review from srl295

@richgillam richgillam Awaiting requested review from richgillam

Assignees

@markusicu markusicu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Begasus @CLAassistant @roubert @srl295 @echeran @mtl1979 @markusicu