Skip to content

Commit

Permalink
Update comments for pending fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
rp9-next committed Aug 23, 2024
1 parent cab1977 commit fbfb8c4
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/icu4c.yml
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,8 @@ jobs:
env:
CC: clang-16
CXX: clang++-16
CPPFLAGS: '-Wall -Wextra -Wno-strict-prototypes -Wctad-maybe-unsupported' # -Werror
# TODO: add '-Werror' after fixing ICU-22873
CPPFLAGS: '-Wall -Wextra -Wno-strict-prototypes -Wctad-maybe-unsupported'
CXXFLAGS: ${{ matrix.flags }}
run: |
cd icu4c/source && ./runConfigureICU --enable-debug --disable-release Linux/clang && make -j -l4.5 check
Expand All @@ -340,7 +341,8 @@ jobs:

- name: ICU4C with clang on MacOS
env:
CPPFLAGS: '-Wall -Wextra -Wextra-semi -Wundef -Wnon-virtual-dtor -Wctad-maybe-unsupported' # -Werror TODO: uncomment warnings as errors
# TODO: add '-Werror' after fixing ICU-22874
CPPFLAGS: '-Wall -Wextra -Wextra-semi -Wundef -Wnon-virtual-dtor -Wctad-maybe-unsupported'
run: |
cd icu4c/source;
PYTHON=python3 ./runConfigureICU MacOSX;
Expand Down

0 comments on commit fbfb8c4

Please sign in to comment.