Skip to content

Commit

Permalink
Add cronjob to exhaustive tests and update docs
Browse files Browse the repository at this point in the history
  • Loading branch information
rp9-next committed Sep 2, 2024
1 parent 330ef8c commit 0bde26c
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 15 deletions.
15 changes: 14 additions & 1 deletion .github/workflows/icu_exhaustive_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,26 @@
# Note: The exhaustive test configuration is in a separate file
# so that it can be run independently from the regular builds.
#
# To run these tests, go to the Actions Tab on the github page,
# To run these tests, go to the Actions Tab of your repo on the github page,
# select "Exhaustive Tests for ICU" and manually trigger the workflow for your branch.

name: Exhaustive Tests for ICU

on:
push:
# Runs post merge on maintenance branches
branches:
- 'maint/maint*'
paths:
- 'icu4c/**'
- 'icu4j/**'
- '.github/workflows/**'
schedule:
# Runs daily on default branch (main) only.
# https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#schedule
- cron: '0 4 * * *' # Run every day at 4:00 UTC
workflow_dispatch:
# Run manually on any branch

jobs:
# Runs exhaustive tests for ICU4J on Linux
Expand Down
4 changes: 2 additions & 2 deletions docs/processes/cldr-icu.md
Original file line number Diff line number Diff line change
Expand Up @@ -379,8 +379,8 @@ If the data is OK , other sources of failure can include:

Exhautive tests should always be run for a CLDR-ICU integration PR before it is merged.
Once you have a PR, you can do this for both C and J as part of the pre-merge CI tests
by adding the following as a comment in the pull request:<br>
`run exhaustive tests` (the exhaustive tests are not run automatically on every PR).
by triggering the exhaustive test flow [manually](../userguide/dev/ci.md#exhaustive-tests)
(these do not run automatically on every PR).

The following instructions run the ICU4C exhaustive tests locally (which you may want to do
before even committing changes, or which may be necessary to diagnose failures in the
Expand Down
17 changes: 5 additions & 12 deletions docs/userguide/dev/gitdev.md
Original file line number Diff line number Diff line change
Expand Up @@ -591,16 +591,9 @@ Send the PR off for review. As in the Easy Way, **you should use the MERGE COMMI

## Requesting an Exhaustive Test run on a Pull-Request (PR)

The ICU4C and ICU4J Exhaustive Tests run on the main branch after a pull-request
has been submitted. They do not run on pull-requests by default as they take 1-2
hours to run.
The ICU4C and ICU4J Exhaustive Tests run on the main branch periodically once
every day (at 4:00 AM UTC) and post merging on the default branches.
They do not run on pull-requests by default as they take 1-2 hours to run.

However, you can manually request the CI builds to run the exhaustive tests on a
PR by commenting with the following text:

```
/azp run CI-Exhaustive
```

This will trigger the test run on the PR. This is covered more in a separate
[document](https://docs.google.com/document/d/1kmcFFUozpWah_y7dk_Inlw_BIq3vG3-ZR2A28tIiXJc/edit?usp=sharing).
However, you can manually request the CI builds to run the exhaustive tests
from GitHub as described [here](./ci.md#exhaustive-tests)

0 comments on commit 0bde26c

Please sign in to comment.