Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17014 Illustrate/fix extra-path bug #4256

Merged
merged 2 commits into from
Jan 13, 2025
Merged

CLDR-17014 Illustrate/fix extra-path bug #4256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4afc3f
CLDR-17014 Illustrate extra-path bug with TestSTFactory.xml
btangmu Dec 24, 2024
5f96bdc
CLDR-17014 Fix extra-path bug with cldrFile.fullIterable
btangmu Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tools/cldr-apps/src/test/resources/org/unicode/cldr/web/data/TestSTFactory.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,4 +236,8 @@
<!-- 8 votes is not enough to change an already-approved item, so the original value (comma) should still be approved -->
<verify status="approved" locale="fr" xpath="//ldml/numbers/symbols[@numberSystem='latn']/decimal">,</verify>

<vote name="A" locale="mul" xpath="//ldml/dates/timeZoneNames/metazone[@type='Alaska']/long/generic">aksalA</vote>
<vote name="B" locale="mul" xpath="//ldml/dates/timeZoneNames/metazone[@type='Alaska']/long/generic">aksalA</vote>
<vote name="C" locale="mul" xpath="//ldml/dates/timeZoneNames/metazone[@type='Alaska']/long/generic">aksalA</vote>
<verify status="approved" locale="mul" xpath="//ldml/dates/timeZoneNames/metazone[@type='Alaska']/long/generic" >aksalA</verify>
</TestSTFactory>
2 changes: 1 addition & 1 deletion tools/cldr-code/src/main/java/org/unicode/cldr/util/CldrXmlWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public CldrXmlWriter(CLDRFile cldrFile, PrintWriter pw, Map<String, ?> options)

xmlSource = cldrFile.dataSource;
orderedSet = new TreeSet<>(cldrFile.getComparator());
xmlSource.forEach(orderedSet::add);
cldrFile.fullIterable().forEach(orderedSet::add);
if (orderedSet.size() > 0) { // May not have any elements.
final String firstPath = orderedSet.iterator().next();
firstFullPath = cldrFile.getFullXPath(firstPath);
Expand Down
Loading