CLDR-17662 update Vetting Participation spreadsheet #3762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
show exception instead of hang in a number of cases where errors were being silently dropped but the UI would hang - when the org list can't be loaded - when viewing the account settings page while not logged in - when a special page's loader throws an exception
- also complete fix of progress percent as a percent
- retain cldr_count as a hidden/deleted column
|
Will want to see the result before approving. Maybe a screen shot (privately, because data) |
I'll send you an updated spreadsheet |
|
@macchiati sent spreadsheet privately. As I noted, I didn’t address Progress Vote, Progress Count, “Main Vetter” yet. If this makes an improvement, we might consider putting this PR into production so it can be tested with real data. Also, should this be allowed for TCs now that it's quicker? Maybe test on Smoketest first and broaden in a future PR. |
|
Ok, let's go ahead and merge. |
macchiati
approved these changes
May 30, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-17662 - Vetting Participation
Does not address all items, but many improvements
Minor:
improve robustness of ST, account, and vetting participation pages.
These are exceptions I hit along the development path. Reduce the number of places where the tool just hangs.
This PR completes the ticket.
ALLOW_MANY_COMMITS=true