CLDR-17665 remove beaufort from GenerateUnitTestData.NOT_CONVERTABLE; 17665 #3741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… regen unit test data
macchiati
approved these changes
May 22, 2024
|
Thanks, looks good. |
pedberg-icu
deleted the
CLDR-17665-GenerateUnitTestData-remove-beaufort-from-NOT_CONVERTABLE
branch
|
BTW, Peter, I was thinking of handling 'generic' in the same way as some other units. That is, create its own Quantity. It would be convertible, but only to itself. That would make the code simpler for us and clients, since everything would have a quantity. |
@macchiati That seems like a great idea! Would presumably need an ICU code change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-17665
Remove
beaufortfrom the NOT_CONVERTABLE list in GenerateUnitTestData since that is no longer correct, then regenerate the unit test data. This regen left alone (as expected) theunitsTest.txtentry forbeaufortwhich had been manually added in PR #3562. It also added entries for 3 new units:ALLOW_MANY_COMMITS=true