-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDR-16101 Change Error Subtype to read from Google Sheets #3649
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, I filed a ticket to make the subtypes be explicitly either errors or warnings, but not both. I think that would make it much clearer.
- config parameter CLDR_SUBTYPE_URL for configuring subtype map - fix reloading page
25cdbc5
to
06f254a
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
- read from sheets instead of parsing HTML - update error type admin panel
5d3ccd1
to
643f4da
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Question: would it be hard to move the "read a spreadsheet" utility into the .util directory? I could see that being very useful for making lots of stuff more dynamic.
This doesn't download, but it does access the data. It reads it into a cache directory in a manner of speaking.
yes, although the authentication bit is interesting. This mode is suitable for a service system, if you are envisioning a command line utility it would be easier to set it up to have the user login locally (slightly different setup). |
CLDR-16101
ALLOW_MANY_COMMITS=true