CLDR-17563 fix unclear test message about attributeValueValidity.xml

[srl295]

• fix an internal function for clarity
• change a constant to a property
• be less cryptic
• drop debug code

CLDR-17563

• This PR completes the ticket.

ALLOW_MANY_COMMITS=true

Example run (fake of course):

-
[INFO] Running org.unicode.cldr.unittest.TestShim
org.unicode.cldr.unittest.testArgs=-n -q -filter:testLSR
CLDR {
  TestCoverageLevel {
    testLSR {
      Error: (TestCoverageLevel.java:1280) : $language in attributeValueValidity.xml needs to include these languages: (7): expected "", got "hnj ie ken kxv lld osa quc"
    } (0.455s) FAILED (1 failure(s), 1 warning(s))
  } (0.462s) FAILED (1 failure(s), 1 warning(s), 11 test(s) skipped)
} (8.012s) FAILED (1 failure(s), 5 warning(s), 496 test(s) skipped)

Error summary:

[jira-pull-request-webhook]

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

[srl295]

trying again without using an unrelated ticket ID

[DavidLRowe]

Not clear on the different ticket numbers (CLDR-17563 in title, CLDR-16818 in description).

From the little I know about Java, the error message seems much more informative!

[srl295]

Not clear on the different ticket numbers (CLDR-17563 in title, CLDR-16818 in description).

From the little I know about Java, the error message seems much more informative!

Fixed

[macchiati]

This is misleading in a different way. The error just indicates that there is a mismatch.

Suggested change

	"$language in attributeValueValidity.xml needs to include these languages: ("
	"There is a mismatch: each language in the following list either needs to be removed from root.xml, OR added to $language in attributeValueValidity.xml: ("

[srl295]

What does "removed from root.xml" mean? In the reproducer, "lld" wasn't in root.xml.

[srl295]

@macchiati any clarification on this?

[macchiati]

Hmmm. Why was lld failing; was it for not being in validity?

[DavidLRowe]

Correct. lld had not been added to validity element in attributeValueValidity.xml

[DavidLRowe]

#3666 changes this wording to: "Language subtags in a locale's ID must be in one of the attributeValueValidity.xml $language* sets, typically $languageNonTcLtBasic (" which is even clearer. I'd also recommend dropping the message change from this PR.

[macchiati]

I won't have time to look at this today.

…

On Fri, Apr 19, 2024 at 12:22 PM Steven R. Loomis ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestCoverageLevel.java <#3647 (comment)>: > @@ -1280,7 +1278,7 @@ public void testLSR() { } } if (!assertEquals( - "Language subtags that are in a CLDR locale's ID are in root (" + "$language in attributeValueValidity.xml needs to include these languages: (" What does "removed from root.xml" mean? In the reproducer, "lld" wasn't in root.xml. — Reply to this email directly, view it on GitHub <#3647 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACJLEMDXM6MPHT2SH2VRU53Y6FVG7AVCNFSM6AAAAABGPNV3Y2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMJSGIYDONRTHA> . You are receiving this because your review was requested.Message ID: ***@***.***>

[srl295]

I won't have time to look at this today.

The other data pr is unblocked. This is just to clarify.

[macchiati]

As a part of #3666, I fixed the messages and added a lot of comments about what is going on in that section. Should be much easier for people to see what is going on. If that is approved, then I think you could drop the rewording part of this PR (but keep the fix to SHOW_LSR_DATA)

[DavidLRowe]

see recommendation to drop message change (since another PR will address that).