CLDR-16369 Move VoteStatus enum from VettingViewer to VoteResolver #3344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-VettingViewer should depend on VoteResolver, not vice-versa
btangmu
commented
Oct 17, 2023
| * The user's organization chose the winning value for the path, but that value is neither | ||
| * contributed nor approved. (see class def for null user) | ||
| */ | ||
| provisionalOrWorse, |
There was a problem hiding this comment.
The comment is wrong -- there is no implication whatsoever about the user's organization
This comment will be fixed in the next PR
srl295
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-VettingViewer should depend on VoteResolver, not vice-versa
CLDR-16369
ALLOW_MANY_COMMITS=true