Remove HTTP_VIA support, support for 3.12 (#14)

* Remove HTTP_VIA * up version * add py 3.12
un33k · Dec 13, 2023 · ad1f017 · ad1f017
1 parent 07840b9
commit ad1f017
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 12 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -20,7 +20,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: [3.7, 3.8, 3.9, "3.10", 3.11, pypy3.9]
+        python-version: [3.7, 3.8, 3.9, "3.10", 3.11, 3.12, pypy3.9]
 
     steps:
       - uses: actions/checkout@v3

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,10 @@
+## 2.0.1
+Issue:
+- Remove `HTTP_VIA` header support (unreliable IP information) (@yourcelf)
+
+Enhance:
+- Include support for python 3.12
+
 ## 2.0.0
 
 - Introduced breaking changes to avoid conflicts with the `django-ipware` package.

diff --git a/README.md b/README.md
@@ -103,7 +103,6 @@ request_headers_precedence_order = (
     "HTTP_X_CLUSTER_CLIENT_IP",  # Rackspace LB and Riverbed Stingray
     "HTTP_FORWARDED_FOR",  # RFC 7239
     "HTTP_FORWARDED",  # RFC 7239
-    "HTTP_VIA",  # Squid and others
     "X-CLIENT-IP",  # Microsoft Azure
     "X-REAL-IP",  # NGINX
     "X-CLUSTER-CLIENT-IP",  # Rackspace Cloud Load Balancers

diff --git a/pyproject.toml b/pyproject.toml
@@ -26,6 +26,7 @@ classifiers = [
     "Programming Language :: Python :: 3.9",
     "Programming Language :: Python :: 3.10",
     "Programming Language :: Python :: 3.11",
+    "Programming Language :: Python :: 3.12",
 ]
 
 [project.urls]

diff --git a/python_ipware/__version__.py b/python_ipware/__version__.py
@@ -1 +1 @@
-__version__ = "2.0.0"
+__version__ = "2.0.1"
diff --git a/python_ipware/python_ipware.py b/python_ipware/python_ipware.py
@@ -26,7 +26,6 @@ def __init__(
             "HTTP_X_CLUSTER_CLIENT_IP",  # Rackspace LB and Riverbed Stingray
             "HTTP_FORWARDED_FOR",  # RFC 7239
             "HTTP_FORWARDED",  # RFC 7239
-            "HTTP_VIA",  # Squid and others
             "X-CLIENT-IP",  # Microsoft Azure
             "X-REAL-IP",  # NGINX
             "X-CLUSTER-CLIENT-IP",  # Rackspace Cloud Load Balancers
@@ -106,7 +105,7 @@ def get_ip_object(
                     ip = ipaddress.IPv4Address(ipv4)
                 except ipaddress.AddressValueError:
                     # not a valid IP address, return None
-                    logging.exception("Invalid ip address. {0}".format(ip_str))
+                    logging.info("Invalid ip address. {0}".format(ip_str))
                     ip = None
         return ip
 

diff --git a/tests/tests_ipv4.py b/tests/tests_ipv4.py
@@ -364,13 +364,6 @@ def test_ipv4_http_http_forwarded(self):
         r = self.ipware.get_client_ip(meta)
         self.assertEqual(r, (IPv4Address("177.139.233.139"), False))
 
-    def test_ipv4_http_via(self):
-        meta = {
-            "HTTP_VIA": "177.139.233.139",
-        }
-        r = self.ipware.get_client_ip(meta)
-        self.assertEqual(r, (IPv4Address("177.139.233.139"), False))
-
     def test_ipv4_x_client_ip(self):
         meta = {
             "X-CLIENT-IP": "177.139.233.139",