refactor(preset-umi): make 3rd-party chunk name clean #11716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Size Change: +29 B (0%) Total Size: 10.2 MB
ℹ️ View Unchanged
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11716 +/- ##
=======================================
Coverage 28.93% 28.93%
=======================================
Files 485 485
Lines 14771 14771
Branches 3498 3498
=======================================
Hits 4274 4274
Misses 9737 9737
Partials 760 760
☔ View full report in Codecov by Sentry. |
This was referenced Oct 9, 2023
fz6m
reviewed
Oct 9, 2023
| @@ -315,9 +315,15 @@ export function componentToChunkName( | |||
| ), | |||
| '', | |||
| ) | |||
| // 丢弃 .pnpm 下的多层 node_modules 避免 chunkName 过长 | |||
| // ex. node_modules/.pnpm/[email protected]_xxxx/node_modules/dumi/dist/client/pages/404 | |||
| .replace(/.+(node_modules(\/|\\))/, '$1') | |||
There was a problem hiding this comment.
这里把全局的 /node_modules(\/|\\)/g 干掉替换为空字符串就好了吧。
There was a problem hiding this comment.
下面的 nm__ 前缀还是有必要的，极端情况下三方包内有可能和源码有一样的文件名
| .replace(/.+(node_modules(\/|\\))/, '$1') | ||
| // 丢弃 tnpm 目录下的软链结构避免 chunkName 过长 | ||
| // ex. node_modules/_@[email protected]@@umijs/utils/dist/index.js | ||
| .replace(/(\/|\\)_@?([^@]+@){2}/, '$1') |
There was a problem hiding this comment.
我感觉只要干掉 _@xxxx/ 这部分，_@ 开头到下一个斜线就好了：
replace( /_@(.+?)(\/|\\)/g, '')
sorrycc
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
对路由表中引用 node_modules 下的路由组件 chunk name 做优化，主要处理 pnpm 和 tnpm 的文件结构，对比效果：
问题背景：之前 dumi 为了解 chunk name 引起的 CDN 资源托管问题（包括但不限于 umijs/dumi#1487 ），用 alias 实现了 chunk name 的优化（见 umijs/dumi#1601 ），但这个实现的前提是 layouts 不会被 server loader 处理，因为 server loader 解析 route component 时不会处理 alias，在 #11666 后 layouts 也会被 server loader 处理，导致 4.0.84 发布后 dumi 应用报错
解决方案：把 chunk name 的简化交给 Umi 来处理 + dumi 回滚之前的方案
为什么不让 server loader 对路由组件的解析支持 alias：加上 alias 的处理也会比较麻烦，需要使用 enhanced-resolve，需要把 getRoutes 变成 async，问题会被扩大