Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

13: Updating steps for adding Two Factor Authentication for Members #6802

Merged
merged 5 commits into from
Jan 17, 2025
Merged

13: Updating steps for adding Two Factor Authentication for Members #6802

merged 5 commits into from
Jan 17, 2025

Conversation

sofietoft
Copy link
Contributor

@sofietoft sofietoft commented Jan 16, 2025 •
edited
Loading

Description

Making the steps to configure Two Factor authentication for Members a more clear.

  • Moved some code explanations into the code snippets as code comments.
  • Updated the article introduction and added section links
  • Added steps for testing the setup
  • Adding images where it made sense

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Other

Product & version (if relevant)

CMS 13.

@sofietoft sofietoft requested a review from eshanrnh January 16, 2025 11:48
@sofietoft sofietoft marked this pull request as ready for review January 16, 2025 11:50
eshanrnh
eshanrnh reviewed Jan 16, 2025
View reviewed changes
Copy link
Contributor

@eshanrnh eshanrnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, @sofietoft 🙌

13/umbraco-cms/reference/security/two-factor-authentication.md Outdated Show resolved Hide resolved
13/umbraco-cms/reference/security/two-factor-authentication.md Outdated Show resolved Hide resolved
13/umbraco-cms/reference/security/two-factor-authentication.md Outdated Show resolved Hide resolved
13/umbraco-cms/reference/security/two-factor-authentication.md Outdated Show resolved Hide resolved
@sofietoft sofietoft changed the title 13: Updating steps for adding Two Factor Authentication 13: Updating steps for adding Two Factor Authentication for Members Jan 17, 2025
@sofietoft sofietoft merged commit 53af04c into main Jan 17, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eshanrnh eshanrnh eshanrnh left review comments

Assignees
No one assigned
Labels
category/umbraco-cms review/docsteam
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sofietoft @eshanrnh