Set this test as disabled for realzies

ultraq · Jul 3, 2016 · 5475572 · 5475572
1 parent 0df36e2
commit 5475572
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/Tests/nz/net/ultraq/thymeleaf/tests/LayoutDialectTestExecutor.groovy b/Tests/nz/net/ultraq/thymeleaf/tests/LayoutDialectTestExecutor.groovy
@@ -53,10 +53,12 @@ class LayoutDialectTestExecutor extends JUnitTestExecutor {
 		def tests = new Reflections('', new ResourcesScanner())
 			.getResources(~/(?!GroupingStrategy|Examples).*\.thtest/) as List
 		def exclusions = [
-		  'nz/net/ultraq/thymeleaf/tests/decorators/Decorate-DeepHierarchy.thtest',
+			'nz/net/ultraq/thymeleaf/tests/decorators/Decorate-DeepHierarchy.thtest',
 			'nz/net/ultraq/thymeleaf/tests/decorators/html/TitlePattern-AllowOtherProcessors.thtest',
-			'nz/net/ultraq/thymeleaf/tests/decorators/html/TitlePattern-DynamicContent.thtest',
-			'nz/net/ultraq/thymeleaf/tests/decorators/html/TitlePattern-ResultAccessible.thtest'
+			'nz/net/ultraq/thymeleaf/tests/decorators/html/TitlePattern-ResultAccessible.thtest',
+
+			// Disabled, see test file for details
+			'nz/net/ultraq/thymeleaf/tests/decorators/html/TitlePattern-DynamicContent.thtest'
 		]
 		return tests - exclusions
 	}

diff --git a/Tests/nz/net/ultraq/thymeleaf/tests/decorators/html/TitlePattern-DynamicContent.thtest b/Tests/nz/net/ultraq/thymeleaf/tests/decorators/html/TitlePattern-DynamicContent.thtest
@@ -2,6 +2,14 @@
 # Test that title patterns can continue to have dynamic content.  Regression in
 # this issue: https://github.com/ultraq/thymeleaf-layout-dialect/issues/64
 
+# TODO: This test is disabled because I haven't decided what I should do for the
+#       error encountered by this, in that the layout:include requests for the
+#       title, but the element is a self-closing one.  The layout:include
+#       processor only fills-in an elements child elements, but a self-closed
+#       one has no children, and I don't think it's safe to force the element
+#       to become an expanded one.  Also, layout:include is deprecated, so I
+#       shouldn't really spend more time on that processor.
+
 %TEMPLATE_MODE HTML
 
 %CONTEXT