Fix/t 59 cpf naming #98
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samueljackson92
requested changes
Dec 9, 2024
|
Looking good, but I think we can do a bit more here. |
khalsz
force-pushed
the
fix/T-59-CPF-Naming
branch
from
637c171 to
7d98858
Compare
samueljackson92
requested changes
Dec 16, 2024
src/api/models.py
Outdated
|
|
||
| cpf_ne0ratio_ipmax: Optional[float] = Field(nullable=True) | ||
| cpf_ne0ratio_ipmax: Optional[float] = Field( | ||
| alias="thom_ne0_rat_line_avg_ne", |
src/api/models.py
Outdated
| cpf_p21022: Optional[float] = Field(nullable=True) | ||
| cpf_p21022: Optional[float] = Field( | ||
| alias="mcs_tf_flattop_time", | ||
| description="(MCS Setup) Param mim421 - TF Flat Top set time (End of Flat Top) for MAST only", |
There was a problem hiding this comment.
-> msc_tf_flat_top_value
src/api/models.py
Outdated
|
|
||
| cpf_p05030: Optional[float] = Field(nullable=True) | ||
| cpf_p05030: Optional[float] = Field( | ||
| alias="mcs_select_p3p_s", |
There was a problem hiding this comment.
Maybe just mcs_select_p3p
khalsz
force-pushed
the
fix/T-59-CPF-Naming
branch
from
82c988a to
46e5cd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.