Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metadata index in intake catalogs. #47

Merged
merged 3 commits into from
Jul 4, 2024

Conversation

samueljackson92
Copy link
Collaborator

This updates the intake catalog descriptions to match how we are now structuring the s3 storage and adding a future option to include different "levels" of data.

To test:

@jameshod5
Copy link
Collaborator

Unable to comment on actual file as it's too large, so going analog mode. Just some typos, runs fine for me:
In `load_data.ipynb':

  • Just above the 3rd cell: "level1 is a source that reads from about level1 sources, which contain data directly from the tokamak. In future, derived sources will be added at other product levels. " > Change to "In the future, ...."

  • Above the 6th cell: "In the next cell we the url of the first shot to remotely open data from the amc diagnostic." > Correct "we the url..."

@samueljackson92
Copy link
Collaborator Author

Thanks @jameshod5 for the quick review. I will update those typos.

@jameshod5
Copy link
Collaborator

Are the conflicts the last part of this PR?

@samueljackson92
Copy link
Collaborator Author

Yup. need to fix my conflicts.

@samueljackson92 samueljackson92 merged commit f0fb5d6 into main Jul 4, 2024
2 checks passed
@samueljackson92 samueljackson92 deleted the samueljackson92/update-metadata-index branch October 15, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants