Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix time-averaged radiation computation #2553

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

LarissaReames-NOAA
Copy link
Collaborator

@LarissaReames-NOAA LarissaReames-NOAA commented Jan 13, 2025

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

This PR fixes incorrect diagnostic output for fhzero-averaged radiation output variables. Presently, there is a significant "sawtooth" appearance to these fields (such as dswrf_ave and ulwrf_avetoa) when we expect smoother lines with jumps only at fhzero diagnostic reset times. Here is an example of the present (OLD) result and the result from the current PR (FIX) from a 24-hour S2S regression test forecast.

iTerm2 RaUnsB rads_fhzero6_fix

Commit Message:

* UFSWM - Fix computation of time-averaged radiation quantities
  * FV3 - Fix computation of time-averaged radiation quantities
    * ccpp-physics - Fix computation of time-averaged radiation quantities

Priority:

  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Updates/Changes Baselines.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • GaeaC5
    • GaeaC6
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@LarissaReames-NOAA
Copy link
Collaborator Author

Full suite of regression tests completed on Hera. All tests with surface files checked fail as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant