update metadata for releasing w/project renames #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashleygwilliams
force-pushed
the
cargo-dist-fix
branch
from
b6fd41e to
ed45c77
Compare
LucioFranco
approved these changes
Nov 16, 2023
ashleygwilliams
force-pushed
the
cargo-dist-fix
branch
4 times, most recently
from
cce7f7f to
09ebc14
Compare
MarinPostma
reviewed
Nov 17, 2023
|
oh huh @MarinPostma that looks correct actually. i'll clean that up. additionally, there's a test i can't run locally due to a lack of a runtime dep i think- so that's the origin of the test failure i believe. will try to sort that but welcome any pointers! |
|
(i'll also manage the conflict) |
|
I fixed the test for you @ashleygwilliams, apparently there were just two missing snapshots 👍 |
ashleygwilliams
force-pushed
the
cargo-dist-fix
branch
from
d20ba30 to
dbffaed
Compare
ashleygwilliams
force-pushed
the
cargo-dist-fix
branch
from
dbffaed to
84ee1e8
Compare
|
(hopping in a call now but will fix my rebase botch when i'm out) |
|
Thanks for the effort @ashleygwilliams 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.