bundle SQLean extensions #1922
Merged
bundle SQLean extensions #1922
+67,523
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A common complain with libSQL is how to run extensions. The main mechanism, with a .so, has a lot of issues around how those .so are distributed. The most common extensions are the ones in the sqlean package. We can improve this experience by bundling them in our sqlite build. Not all SQLean extensions are kosher: some of them, like fileio, use the vfs. Others, are deemed too complex. The extensions included here are a subset that we deem important enough, and low risk enough, to just be a part of the main bundle.
glommer
force-pushed
the
glauber/sqlean
branch
from
90ff416 to
d3a156c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A common complain with libSQL is how to run extensions. The main mechanism, with a .so, has a lot of issues around how those .so are distributed.
The most common extensions are the ones in the sqlean package. We can improve this experience by bundling them in our sqlite build.
Not all SQLean extensions are kosher: some of them, like fileio, use the vfs. Others, are deemed too complex.
The extensions included here are a subset that we deem important enough, and low risk enough, to just be a part of the main bundle.
The file sqlean.c has the registration function so that the extensions are enabled in every connection.
The file sqlite3-sqlean-stripped.c is the stripped down version of sqlite3-sqlean.c from the bundle, with the extensions we don't want to enable removed.