Make it possible to use offline writes in C bindings #1840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penberg
approved these changes
Nov 25, 2024
LucioFranco
suggested changes
Nov 25, 2024
haaawk
force-pushed
the
opsqlite_offline
branch
from
7eb42d4 to
e442c53
Compare
Signed-off-by: Piotr Jastrzebski <[email protected]>
Signed-off-by: Piotr Jastrzebski <[email protected]>
…has query param Signed-off-by: Piotr Jastrzebski <[email protected]>
haaawk
force-pushed
the
opsqlite_offline
branch
from
e442c53 to
7e6d74f
Compare
LucioFranco
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to make it possible to test offline writes in opsqlite.
To make the integration easy we don't create a new factory function but modify
libsql_open_sync_with_configto create offline writes database if primary url containsofflinequery parameter.