sqld: schema db and replica fixes #1750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucioFranco
commented
Sep 19, 2024
LucioFranco
force-pushed
the
lucio/clean-up-schema-replica
branch
from
529b854 to
2a6fbe2
Compare
LucioFranco
force-pushed
the
lucio/clean-up-schema-replica
branch
from
2a6fbe2 to
1f0c9df
Compare
MarinPostma
approved these changes
Sep 19, 2024
| ) | ||
| .unwrap(); | ||
| let conn = db.connect().unwrap(); | ||
| conn.execute("select * from sqlite_master;", ()) |
There was a problem hiding this comment.
this looks like exactly the same test as the one in cluster/mod no?
There was a problem hiding this comment.
I copied portions of it but I don't think we ran it through this path specifically?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two fixes one for preventing embedded replica's from being able to sync a schema db and another that cleans up the conn.is_primary panics/errors that we had before.