vector search: hide vector index for sqlite planner #1678
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
PR #1594 tried to solve issue with sqlite planner using vector index for some optimizations (for example in
SELECT COUNT(*) FROM t
queries).Turned out hacks to avoid usage of vector indices in planner were not enough. Actually,
bUnordered
field set bysqlite3
during index analysis process and manipulating with it can be dangerous and error-prone (as sqlite3 can reset it at any moment).So, this PR fixes this more robustly:
opMask
is set to 0 for vector index inwhereLoopAddBtreeIndex
which must additionally prevent sqlite to use index in any operations (>
,>=
,=
,IN
) (actually, it shouldn't happen because index has expression - but still - this is another guard)whereIsCoveringIndex
return false for vector indexbUnordered
indices were extended to have additional check foridxIsVector
field