Allow multiple namespaces types to be stored in the same NamespaceStore
#1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
MarinPostma
force-pushed
the
db-unify
branch
4 times, most recently
from
164af39 to
47eff78
Compare
MarinPostma
changed the title
NamespaceStore
stores different kinds of databases int the same type, and multiplex the connection type the same way.
MarinPostma
force-pushed
the
db-unify
branch
from
47eff78 to
7779f05
Compare
- Namespace store is not generic over the Namespace anymore - create method takes a config - simplify loading namespaces
Namespace is not generic on db type anymore, but used the multiplexed database types instead.
allows mapping the connection type, when wrapping it in database/mod.rs
where it's being used
MarinPostma
force-pushed
the
db-unify
branch
from
7779f05 to
56bc743
Compare
Horusiath
reviewed
Feb 27, 2024
Horusiath
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors sqld to allow the NamespaceStore to store different kinds of namespaces. For now this means only replica and primaries, but this paves the way to storing schema databases as well.