Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add textual mouseover descriptions of collapsed nodes #3051

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

hyanwong
Copy link
Member

@hyanwong hyanwong commented Nov 14, 2024

I realised that the numbers can be somewhat cryptic, and it's trivial to add helpful text that appears on mouseover, e.g. "This polytomy has 3 additional branches, leading to a total of 14 descendant samples"

PR Checklist:

  • Tests that fully cover new/changed functionality.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.86%. Comparing base (af21766) to head (4a3b35b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3051   +/-   ##
=======================================
  Coverage   89.86%   89.86%           
=======================================
  Files          29       29           
  Lines       32150    32155    +5     
  Branches     5768     5768           
=======================================
+ Hits        28890    28895    +5     
  Misses       1859     1859           
  Partials     1401     1401           
Flag Coverage Δ
c-tests 86.71% <ø> (ø)
lwt-tests 80.78% <ø> (ø)
python-c-tests 89.05% <ø> (ø)
python-tests 98.98% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/tskit/drawing.py 99.24% <100.00%> (+<0.01%) ⬆️

@benjeffery benjeffery added the AUTOMERGE-REQUESTED Ask Mergify to merge this PR label Dec 2, 2024
@hyanwong hyanwong force-pushed the fix-polytomy-drawing branch from a21cb92 to df5eb80 Compare December 2, 2024 22:03
@benjeffery benjeffery force-pushed the fix-polytomy-drawing branch from df5eb80 to 0df2868 Compare January 8, 2025 12:37
@benjeffery
Copy link
Member

@Mergifyio rebase

I realised that the numbers can be somewhat cryptic, and it's trivial to add helpful text that appears on mouseover, e.g. "This polytomy has 3 additional branches, leading to a total of 14 descendant samples"
Copy link
Contributor

mergify bot commented Jan 8, 2025

rebase

✅ Branch has been successfully rebased

@benjeffery benjeffery force-pushed the fix-polytomy-drawing branch from 0df2868 to 4a3b35b Compare January 8, 2025 12:38
@mergify mergify bot merged commit ffecae9 into tskit-dev:main Jan 8, 2025
21 checks passed
@mergify mergify bot removed the AUTOMERGE-REQUESTED Ask Mergify to merge this PR label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants