Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow VariantData to take either a vcz path or the zarr store itself #966

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

hyanwong
Copy link
Member

@hyanwong hyanwong commented Sep 5, 2024

Starts to address #924

Changes are very minor: most of this is just in testing

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.17%. Comparing base (6c02f9d) to head (fe0b969).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #966   +/-   ##
=======================================
  Coverage   93.16%   93.17%           
=======================================
  Files          18       18           
  Lines        6337     6343    +6     
  Branches     1133     1134    +1     
=======================================
+ Hits         5904     5910    +6     
  Misses        294      294           
  Partials      139      139           
Flag Coverage Δ
C 93.17% <100.00%> (+<0.01%) ⬆️
python 95.54% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@benjeffery benjeffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hyanwong!

@benjeffery
Copy link
Member

@Mergifyio rebase

Copy link
Contributor

mergify bot commented Sep 5, 2024

rebase

☑️ Nothing to do

  • -conflict [📌 rebase requirement]
  • -closed [📌 rebase requirement]
  • queue-position=-1 [📌 rebase requirement]
  • any of:
    • #commits-behind>0 [📌 rebase requirement]
    • #commits>1 [📌 rebase requirement]
    • -linear-history [📌 rebase requirement]

…self

Add check for badly formatted vcz.

Just looks for the dimensions of the call_genotype array, but that's most likely to be wrong (e.g. 2d by mistake)
@mergify mergify bot merged commit 788d4df into tskit-dev:main Sep 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants