Skip to content

Commit

Permalink
Merge pull request #345 from jeromekelleher/workaround-windows
Browse files Browse the repository at this point in the history
Temporarily disable some threading tests on Windows.
  • Loading branch information
jeromekelleher authored Jan 14, 2018
2 parents 6ae8e09 + 41552b2 commit 8f63bc4
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion tests/test_threads.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,15 @@
import sys
import threading
import unittest
import platform

import numpy as np

import msprime
import tests.tsutil as tsutil

IS_PY2 = sys.version_info[0] < 3
IS_WINDOWS = platform.system() == "Windows"


def run_threads(worker, num_threads):
Expand Down Expand Up @@ -171,7 +173,10 @@ def worker(thread_index, results):
self.assertEqual(results[j][0], m - j - 1)


@unittest.skipIf(IS_PY2, "Cannot test thread support on Py2.")
# @unittest.skipIf(IS_PY2, "Cannot test thread support on Py2.")
# Temporarily skipping these on windows too. See
# https://github.com/jeromekelleher/msprime/issues/344
@unittest.skipIf(IS_PY2 or IS_WINDOWS, "Cannot test thread support on Py2.")
class TestTables(unittest.TestCase):
"""
Tests to ensure that attempts to access tables in threads correctly
Expand Down

0 comments on commit 8f63bc4

Please sign in to comment.