Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some Improvements #120

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Some Improvements #120

wants to merge 5 commits into from

Conversation

mah454
Copy link

@mah454 mah454 commented Apr 3, 2024 •
edited
Loading

  1. Fix gradle repositories
  2. add transfer with contract method
  3. CleanUp README.md
  4. Add new UnitTest

@lvs007 lvs007 requested a review from eodiandie May 10, 2024 03:07
@angrynurd
Copy link
Contributor

really a good pull request. especially the unit test added.

0xbigapple
0xbigapple reviewed Dec 27, 2024
View reviewed changes
Copy link

@0xbigapple 0xbigapple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. transfer for TRC20 method describe error
  2. It is not recommended to write the private key in the code
  3. This branch has conflicts that must be resolved

trident-java/core/src/main/java/org/tron/trident/core/ApiWrapper.java
@@ -435,6 +439,35 @@ public TransactionExtention transfer(String fromAddress, String toAddress, long
return txnExt;
}

/**
* Transfer TRX. amount in SUN
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments and methods do not match.

trident-java/core/src/test/java/org/tron/trident/core/inceptors/TronWalletTest.java
/**
* Test privateKey (Not important)
*/
private static final String MAIN_WALLET_PRIVATE_KEY = "18ef152ae3711498556a22db1f820f33f27080aea51b19d39fdb6752a0591e1f";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not recommended to display private keys in plaintext.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xbigapple 0xbigapple 0xbigapple left review comments

@eodiandie eodiandie Awaiting requested review from eodiandie

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mah454 @angrynurd @0xbigapple