feat(consensus): add consensus logic optimization proposal #6141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halibobo1205
reviewed
Jan 9, 2025
| if (!forkController.pass(ForkBlockVersionEnum.VERSION_4_8_0)) { | ||
| throw new ContractValidateException( | ||
| "Bad chain parameter id [CONSENSUS_LOGIC_OPTIMIZATION]"); | ||
| } |
There was a problem hiding this comment.
[CONSENSUS_LOGIC_OPTIMIZATION] has been valid, no need to propose again.
There was a problem hiding this comment.
OK, I have seen many proposals that do not implement this judgment logic, such as ALLOW_TVM_SHANGHAI, ALLOW_OPTIMIZED_RETURN_VALUE_OF_CHAIN_ID
halibobo1205
reviewed
Jan 9, 2025
| new BytesCapsule(ByteArray.fromLong(value))); | ||
| } | ||
|
|
||
| public long getConsensusLogicOptimization() { |
There was a problem hiding this comment.
public boolean allowConsensusLogicOptimization() {
return getConsensusLogicOptimization() == 1L;
}
halibobo1205
reviewed
Jan 9, 2025
| @@ -27,6 +24,8 @@ | |||
| import org.tron.core.capsule.BlockCapsule; | |||
| import org.tron.core.capsule.WitnessCapsule; | |||
|
|
|||
| import static org.tron.core.config.Parameter.ChainConstant.*; | |||
There was a problem hiding this comment.
check style do not allow *
There was a problem hiding this comment.
OK, but the local check style is passed.
fyyhtx
approved these changes
Jan 15, 2025
halibobo1205
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add consensus logic optimization proposal.
Why are these changes required?
This PR has been tested by:
Follow up
Extra details