Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proof of Concept] Very simple prototype for an MPI implementation #698

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

efaulhaber
Copy link
Member

@efaulhaber efaulhaber commented Jan 14, 2025

Requires trixi-framework/PointNeighbors.jl#92.

This is a very simple prototype for a first MPI implementation. We can run a "static" simulation on multiple ranks, by which I mean that particles are not moving out of their rank's domain partition. Sending particles from one rank to another is not implemented yet, neither on the TrixiParticles nor the PointNeighbors side.

On two ranks, the ghost particles are outside of the nhs grid.
We need to query the ghost cells from p4est to create a separate grid for the ghost system nhs.
Then,  rank 0 exits the integration with NaNs, while rank 1 continues and blocks.
@efaulhaber efaulhaber added the hpc label Jan 14, 2025
@sloede
Copy link
Member

sloede commented Jan 16, 2025

Very cool! What's the major challenge to implementing full simulations (i.e., with particles migrating across MPI subdomain boundaries)?

@efaulhaber
Copy link
Member Author

What's the major challenge to implementing full simulations (i.e., with particles migrating across MPI subdomain boundaries)?

Implementing it and spending all the time to debug everything and to make it ready for a clean PR. We changed a lot of internals here.
And we will have to implement a monolithic NHS that manages the domain partitioning and then stores all cell lists for individual systems. Currently we have one NHS for each pair of systems.
Also, resizing of the systems when particles change ranks is required.

@sloede
Copy link
Member

sloede commented Jan 16, 2025

What's the major challenge to implementing full simulations (i.e., with particles migrating across MPI subdomain boundaries)?

Implementing it and spending all the time to debug everything and to make it ready for a clean PR. We changed a lot of internals here. And we will have to implement a monolithic NHS that manages the domain partitioning and then stores all cell lists for individual systems. Currently we have one NHS for each pair of systems. Also, resizing of the systems when particles change ranks is required.

Thanks. There are some incoming master students, one or two of whom might be up for a challenge. I'll reach out to you if I found someone who is interested and then we can see if it is feasible or not.

@efaulhaber
Copy link
Member Author

I think it's feasible for a good student. I would say it's similar to what I did in my thesis. Although we would have to work closely with the student to figure out how to cleanly integrate this into our current code.

@sloede
Copy link
Member

sloede commented Jan 16, 2025

I think it's feasible for a good student. I would say it's similar to what I did in my thesis.

Thanks for your estimate!

Although we would have to work closely with the student to figure out how to cleanly integrate this into our current code.

Absolutely, I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants