Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the time integration method used in DualSPHysics #693

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

efaulhaber
Copy link
Member

No description provided.

@efaulhaber efaulhaber added the enhancement New feature or request label Jan 3, 2025
@efaulhaber efaulhaber self-assigned this Jan 3, 2025
@@ -31,6 +31,12 @@ TimerOutputs = "a759f4b9-e2f1-59dc-863e-4aeb61b1ea8f"
TrixiBase = "9a0f1c46-06d5-4909-a5a3-ce25d3fa3284"
WriteVTK = "64499a7a-5c06-52f2-abe2-ccb03c286192"

[weakdeps]
OrdinaryDiffEqCore = "bbf590c4-e513-4bbe-9b18-05decba2e5d8"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunatly,

using TrixiParticles, OrdinaryDiffEq

doesn't make this extension available. I have to explicitly add and import OrdinaryDiffEqCore.
How do I make this work with just using OrdinaryDiffEq?
In the extension, I need to import OrdinaryDiffEqCore.
@sloede ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, then you should have OrdinaryDiffEq as the trigger for the pkgext. I am sure you can finagle OrdinaryDiffEq from it, either by then doing

using OrdinaryDiffEq.OrdinaryDiffEqCore

or if this does not work, I am sure one of the dependencies of OrdinaryDiffEq will have the Core package available as a name.

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.50%. Comparing base (e5a8834) to head (479874e).

Files with missing lines Patch % Lines
src/general/time_integration.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #693      +/-   ##
==========================================
- Coverage   68.51%   68.50%   -0.02%     
==========================================
  Files          87       88       +1     
  Lines        5406     5407       +1     
==========================================
  Hits         3704     3704              
- Misses       1702     1703       +1     
Flag Coverage Δ
unit 68.50% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -0,0 +1,13 @@
# Time integration is handles by the package OrdinaryDiffEq.jl.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Time integration is handles by the package OrdinaryDiffEq.jl.
# Time integration is handled by the package OrdinaryDiffEq.jl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants