Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialize rectangular tank with hydrostatic pressure #246
Initialize rectangular tank with hydrostatic pressure #246
Changes from 2 commits
f9ae922
e2e1e03
51ba1c4
cb83df3
d58dce7
e4c5917
5d3b13d
9ce5cde
973102f
206e1ba
fc73743
ceb4b90
8397c16
b1bc1b1
f4c268a
a8c75bb
e62c3cd
da720e4
a9ccc3f
f2f7981
f282cba
cc412ae
91cb680
87ddfff
9fd72e3
5105de5
714cf95
390313e
05d6e4a
1a0cfc9
7a7672a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't get it. In 3D, we would need 3 nested loops to get all particle IDs. This just seems to loop over
sum(n_particles_per_dimension)
particles and not overprod(n_particles_per_dimension)
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about looping only over the one dimension where gravity is not zero (this setup doesn't really make sense for diagonal accelerations anyway), but this would make the code longer.