Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement allow all tracing for OPs #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implement allow all tracing for OPs #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/trailblazer/pro/session.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,9 @@ module DSL
def trace_operations(operation_hash)
decisions =
if operation_hash == :all
Trailblazer::Operation.extend(Trailblazer::Pro::Operation::Call)
Trailblazer::Operation.extend(Trailblazer::Pro::Operation::Call) # extend all OPs.

raise "implement me"
[->(*) { [Trace::Wtf, {}] }]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!!! 🌞 ☕ but we need to add a test for that, unfortunately...

elsif operation_hash.is_a?(Hash)
operation_hash.collect do |operation, strategy| # DISCUSS: this can be easily made faster for runtime.
operation.extend(Trailblazer::Pro::Operation::Call) # only extend selected OPs.
Expand Down