Add grape controller module with test application #16
Conversation
|
|
||
| def endpoint_for(name, config_source: self.class) |
There was a problem hiding this comment.
Any specific reason for removing this config_source arg? 🌷
There was a problem hiding this comment.
Couldn't you override the entire method instead, for grape.rb and change the defaulting there?
There was a problem hiding this comment.
Hmm, do you mean override endpoint_for itself ?
We actually need config_source in other methods too (API.endpoint and compile_options_for_controller).
lib/trailblazer/endpoint.rb
Outdated
| @@ -145,4 +145,5 @@ def self.advance_from_controller(endpoint, success_block:, failure_block:, proto | |||
| require "trailblazer/endpoint/adapter" | |||
| require "trailblazer/endpoint/dsl" | |||
| require "trailblazer/endpoint/controller" | |||
| require "trailblazer/endpoint/grape/controller" | |||
There was a problem hiding this comment.
Shouldn't we require that for grape environments, only?
There was a problem hiding this comment.
You're right, I've removed it.
yogeshjain999
force-pushed
the
grape-integration
branch
from
82052a7 to
77b1fab
Compare
yogeshjain999
force-pushed
the
grape-integration
branch
from
77b1fab to
23f6e9f
Compare
yogeshjain999
force-pushed
the
grape-integration
branch
from
23f6e9f to
1631d40
Compare
Good point, I'll look into it. |
Trailblazer::Endpoint::Grape::Controllerto make.endpoint,.directive&#endpointavailable in Grape classesGrape::APIclasses work. They're not copying@normalizerssettings.