Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix roles for types module #516

Merged
merged 3 commits into from
Jan 16, 2025
Merged

Fix roles for types module #516

merged 3 commits into from
Jan 16, 2025

Conversation

flying-sheep
Copy link
Contributor

@flying-sheep flying-sheep commented Jan 16, 2025 •
edited
Loading

Fixes #498

Also apparently the emitted role for FunctionType used to be wrong, so fixes that as well.

@hoodmane
Copy link
Collaborator

Could you add a few more tests for class vs data from your tables in #498?

hoodmane
hoodmane previously approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@hoodmane hoodmane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me, but we should add more tests for this.

@flying-sheep flying-sheep requested a review from hoodmane January 16, 2025 11:17
@hoodmane hoodmane merged commit aceb328 into tox-dev:main Jan 16, 2025
8 checks passed
@flying-sheep flying-sheep deleted the pa/types-roles branch January 16, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoodmane hoodmane hoodmane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle types.EllipsisType (and friends?)
2 participants
@flying-sheep @hoodmane