Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pre-commit.ci] pre-commit autoupdate #515

Merged
merged 2 commits into from
Jan 16, 2025
Merged

[pre-commit.ci] pre-commit autoupdate #515

merged 2 commits into from
Jan 16, 2025

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Jan 6, 2025 •
edited by hoodmane
Loading

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from edf7d12 to 2485866 Compare January 13, 2025 16:53
@gaborbernat gaborbernat enabled auto-merge (squash) January 13, 2025 18:07
@flying-sheep
Copy link
Contributor

@gaborbernat this one isn’t automatic, see #517

@hoodmane
Copy link
Collaborator

Thanks @flying-sheep!

@hoodmane
Copy link
Collaborator

@flying-sheep do you know how to request the bot to update this PR?

@flying-sheep
Copy link
Contributor

pre-commit.ci run

@flying-sheep
Copy link
Contributor

flying-sheep commented Jan 16, 2025 •
edited
Loading

it thumbed me down because I don’t have the permissions, but if you do that, it should work

@hoodmane
Copy link
Collaborator

pre-commit.ci run

@hoodmane
Copy link
Collaborator

Well that reruns the ci on this PR but it doesn't seem to merge. I guess I'll have to do it manually.

@flying-sheep
Copy link
Contributor

yeah, I think we should just close this and manually bump check-jsonschema.

or close it and wait a week

@pre-commit-ci @hoodmane
[pre-commit.ci] pre-commit autoupdate
d121bad 
updates:
- [github.com/python-jsonschema/check-jsonschema: 0.30.0 → 0.31.0](python-jsonschema/check-jsonschema@0.30.0...0.31.0)
@hoodmane hoodmane force-pushed the pre-commit-ci-update-config branch from 8e0e36a to d121bad Compare January 16, 2025 11:48
@hoodmane
Copy link
Collaborator

New changes require approval from someone other than hoodmane because they were the last pusher.

Annoying.

@gaborbernat gaborbernat merged commit 02ce766 into main Jan 16, 2025
8 checks passed
@gaborbernat gaborbernat deleted the pre-commit-ci-update-config branch January 16, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flying-sheep flying-sheep flying-sheep left review comments

@hoodmane hoodmane hoodmane approved these changes

@gaborbernat gaborbernat gaborbernat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flying-sheep @hoodmane @gaborbernat