Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a different DB for E2E testing #398

Conversation

josecelano
Copy link
Member

@josecelano josecelano commented Nov 20, 2023

To avoid accidentally overwriting the default database.

@josecelano josecelano linked an issue Nov 20, 2023 that may be closed by this pull request
@josecelano josecelano force-pushed the issue-392-different-database-for-e2e-testing branch from f0048d8 to fe73140 Compare November 20, 2023 11:48
@josecelano josecelano marked this pull request as draft November 20, 2023 12:24
@josecelano josecelano force-pushed the issue-392-different-database-for-e2e-testing branch from fe73140 to de26426 Compare November 22, 2023 16:23
@josecelano josecelano force-pushed the issue-392-different-database-for-e2e-testing branch from de26426 to 11727f3 Compare November 22, 2023 16:40
@josecelano josecelano force-pushed the issue-392-different-database-for-e2e-testing branch from 11727f3 to 0a309d8 Compare November 22, 2023 16:57
to avoid accidentally overwriting the default database.
@josecelano josecelano force-pushed the issue-392-different-database-for-e2e-testing branch from 0a309d8 to 052e855 Compare November 22, 2023 17:13
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fa3bba7) 42.27% compared to head (052e855) 42.27%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #398   +/-   ##
========================================
  Coverage    42.27%   42.27%           
========================================
  Files           80       80           
  Lines         4887     4887           
========================================
  Hits          2066     2066           
  Misses        2821     2821           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josecelano josecelano marked this pull request as ready for review November 22, 2023 17:29
@josecelano
Copy link
Member Author

ACK 052e855

@josecelano josecelano merged commit c17ebbd into torrust:develop Nov 22, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Don't use the default container databases for E2E testing
2 participants