Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use normal variables instead of secrets for user and repo on DockerHub #381

Merged

Conversation

josecelano
Copy link
Member

From: torrust/index-backend:develop
To: torrust/index:develop

From: `torrust/index-backend:develop`
To: `torrust/index:develop`
@josecelano josecelano requested a review from a team as a code owner November 13, 2023 16:26
@josecelano josecelano requested a review from da2ce7 November 13, 2023 16:27
@josecelano josecelano linked an issue Nov 13, 2023 that may be closed by this pull request
@josecelano
Copy link
Member Author

In order to rename the docker image we only need to change the GitHub env variables and trigger the container workflow again to publish the image.

But I have made some changes anyway:

image

I've created new env variables for the DockerHub user and repo instead of using secrets. I think we do not need secrets for that and It can help to find errors in the pipeline.

Copy link
Contributor

@da2ce7 da2ce7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed not related to rename, but good refactor anyhow.

@josecelano josecelano changed the title Rename docker image Use normal variables instead of secrets for user and repo on DockerHub Nov 13, 2023
@josecelano josecelano changed the title Use normal variables instead of secrets for user and repo on DockerHub Use normal variables instead of secrets for user and repo on DockerHub Nov 13, 2023
@josecelano
Copy link
Member Author

josecelano commented Nov 13, 2023

Changed not related to rename, but good refactor anyhow.

Updated.

@josecelano
Copy link
Member Author

ACK b93564c

@josecelano josecelano merged commit 48ec4b1 into torrust:develop Nov 13, 2023
13 checks passed
@josecelano
Copy link
Member Author

I've removed the unused secrets:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Rename docker image from torrust/index-backend to torrust/index
2 participants