feat: [#303] store in the database the torrent fields creation_date c… #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #315 +/- ##
===========================================
- Coverage 42.47% 42.34% -0.13%
===========================================
Files 79 79
Lines 4801 4822 +21
===========================================
+ Hits 2039 2042 +3
- Misses 2762 2780 +18
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mario-nt
force-pushed
the
303-store-in-the-database-the-torrent-fields-creation-date-created-by-encoding
branch
from
1c9e212 to
07cfb86
Compare
mario-nt
force-pushed
the
303-store-in-the-database-the-torrent-fields-creation-date-created-by-encoding
branch
from
07cfb86 to
c302735
Compare
mario-nt
force-pushed
the
303-store-in-the-database-the-torrent-fields-creation-date-created-by-encoding
branch
from
4f57273 to
cbbfe40
Compare
mario-nt
force-pushed
the
303-store-in-the-database-the-torrent-fields-creation-date-created-by-encoding
branch
from
cbbfe40 to
0866ae3
Compare
mario-nt
force-pushed
the
303-store-in-the-database-the-torrent-fields-creation-date-created-by-encoding
branch
from
0866ae3 to
911c387
Compare
mario-nt
force-pushed
the
303-store-in-the-database-the-torrent-fields-creation-date-created-by-encoding
branch
from
911c387 to
078e086
Compare
mario-nt
force-pushed
the
303-store-in-the-database-the-torrent-fields-creation-date-created-by-encoding
branch
from
078e086 to
bdc9932
Compare
mario-nt
force-pushed
the
303-store-in-the-database-the-torrent-fields-creation-date-created-by-encoding
branch
from
4993082 to
af85b6a
Compare
mario-nt
force-pushed
the
303-store-in-the-database-the-torrent-fields-creation-date-created-by-encoding
branch
from
af85b6a to
d6ea4a1
Compare
josecelano
force-pushed
the
303-store-in-the-database-the-torrent-fields-creation-date-created-by-encoding
branch
from
d6ea4a1 to
7d9e887
Compare
|
Hi @mario-nt this needs a rebase. I tried to do it with the GitHub UI, but commits are not verified. |
mario-nt
force-pushed
the
303-store-in-the-database-the-torrent-fields-creation-date-created-by-encoding
branch
from
7d9e887 to
594a70a
Compare
|
@josecelano Rebase done and tests OK, we need to update the types and API libs before merging to make this PR work. I will update the types lib and then update the dependencies in the API lib. |
josecelano
added
Needs Rebase
I've released the new types https://www.npmjs.com/package/torrust-index-types-lib/v/1.0.0-alpha.4 |
added 4 commits
November 7, 2023 16:44
…_date created_by encoding API responses now contain the three field in the - Torrent details endpoint - Torrent list endpoint
…tion_date created_by encoding Fixed linting errors
…tion date created_by encoding Fix mysql type for creation_date column
… date created_by encoding Added bindings to the add torrent query in the mysql implementation for the new added fields
mario-nt
force-pushed
the
303-store-in-the-database-the-torrent-fields-creation-date-created-by-encoding
branch
from
594a70a to
e8772f3
Compare
…tion date created by encoding
-Added backticks for mysql so the encoding column name is not interpreted as a reserved keyword
mario-nt
force-pushed
the
303-store-in-the-database-the-torrent-fields-creation-date-created-by-encoding
branch
from
e8772f3 to
c22f661
Compare
|
@josecelano Ready to be merged. |
|
ACK c22f661 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #303.