Merge #744: ci: add workaround for broken clipply lint

697c693 ci: make tempory exception for  lint (Cameron Garnham)
d79ca62 clippy: refactor to define lints in Cargo.toml manifest (Cameron Garnham)

Pull request description:

  - [x] Fixes #741

ACKs for top commit:
  josecelano:
    ACK 697c693

Tree-SHA512: 2bdd4570a7e9031e38a6129f5bb9fc526a5e9c818f57e2c591d16dbdf83e8a3aa417ab0b330839ed4de2342ee9c7bd1a785735dc76e5c58d9827caac4313b700

.github/workflows/testing.yaml

@@ -73,7 +73,7 @@ jobs:
 
       - id: lint
         name: Run Lint Checks
-        run: cargo clippy --tests --benches --examples --workspace --all-targets --all-features -- -D clippy::correctness -D clippy::suspicious -D clippy::complexity -D clippy::perf -D clippy::style -D clippy::pedantic
+        run: cargo clippy --tests --benches --examples --workspace --all-targets --all-features
 
       - id: docs
         name: Lint Documentation

.vscode/settings.json

@@ -5,21 +5,6 @@
   "rust-analyzer.checkOnSave": true,
   "rust-analyzer.check.command": "clippy",
   "rust-analyzer.check.allTargets": true,
-  "rust-analyzer.check.extraArgs": [
-    "--",
-    "-D",
-    "clippy::correctness",
-    "-D",
-    "clippy::suspicious",
-    "-W",
-    "clippy::complexity",
-    "-W",
-    "clippy::perf",
-    "-W",
-    "clippy::style",
-    "-W",
-    "clippy::pedantic",
-  ],
   "evenBetterToml.formatter.allowedBlankLines": 1,
   "evenBetterToml.formatter.columnWidth": 130,
   "evenBetterToml.formatter.trailingNewline": true,

Cargo.toml

@@ -103,3 +103,14 @@ uuid = { version = "1", features = ["v4"] }
 tempfile = "3"
 uuid = { version = "1", features = ["v4"] }
 which = "6"
+
+[lints.clippy]
+complexity = { level = "deny", priority = -1 }
+correctness = { level = "deny", priority = -1 }
+pedantic = { level = "deny", priority = -1 }
+perf = { level = "deny", priority = -1 }
+style = { level = "deny", priority = -1 }
+suspicious = { level = "deny", priority = -1 }
+
+# temp allow this lint
+needless_return = "allow"