Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the problem when executing fill_table twice #168

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

LukasFehring
Copy link
Collaborator

@LukasFehring LukasFehring commented Feb 14, 2024

Description

Fix issue form mentioned issue

Motivation and Context

Newer versions of mysql return table columns sorted alphabetically. Our previous codebases hardcoded checking whether the structure was correct, which does not work anymore.

Changes

Decide flexibly whether or not a table is of correct structure

Type Of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How has This Been Tested?

  • Database provider: mysql
  • Python version: Any
  • Operating System: Any

Instead of selecting relevant columns from the datbase to compare, all irrelevant coluns (such as start date) are deleted before comparing

Does this Close/Impact Existing Issues?

What is Missing?

Nothin

Checklist

  • My change is based on the latest stage of the develop branch.
  • My change required a change of the documentation, which has been done.
  • I checked that the documentation can be build, visualizes everything as expected, and does not contain any warnings.
  • I have added/adapted tests to cover my changes.
  • The tests can be executed successfully.
  • The notebooks can be executed successfully.
  • The notebooks can be executed with mysql as provider.
  • I have added a description of the changes to CHANGELOG.rst.

@LukasFehring LukasFehring linked an issue Feb 14, 2024 that may be closed by this pull request
@tornede tornede merged commit 9b523ca into develop Feb 15, 2024
7 checks passed
@tornede tornede deleted the 167-problem-when-executing-fill_table-twice branch February 15, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem when executing fill_table twice
2 participants