Skip to content

Commit

Permalink
Remove test
Browse files Browse the repository at this point in the history
  • Loading branch information
miguelreiswildlife committed Mar 13, 2024
1 parent 0de6097 commit 96bc6c6
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 13 deletions.
2 changes: 2 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ test-unit:
@echo "= Running unit tests... ="
@echo "-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-="
@echo
@export ACK_GINKGO_RC=true
@$(GINKGO) -trace -r --randomizeAllSpecs --randomizeSuites --cover --focus="\[Unit\].*" .
@$(MAKE) test-coverage-func
@echo
Expand All @@ -118,6 +119,7 @@ run-integration-test:
@echo "= Running integration tests... ="
@echo "-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-="
@echo
@export ACK_GINKGO_RC=true
@ginkgo -trace -r -tags=integration --randomizeAllSpecs --randomizeSuites --focus="\[Integration\].*" .
# [Integration] Listener Use From GCM [It] should delete a single token from a game
@echo
Expand Down
1 change: 0 additions & 1 deletion extensions/kafka_consumer.go
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,6 @@ func (q *KafkaConsumer) handleError(err error) {
"extension": "kafka-consumer",
})
l.WithError(err).Error("Error in Kafka connection.")
close(q.stopChannel)
}

// Cleanup closes kafka consumer connection
Expand Down
12 changes: 0 additions & 12 deletions extensions/kafka_consumer_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ import (
"github.com/spf13/viper"
"github.com/topfreegames/pusher/interfaces"
"github.com/topfreegames/pusher/mocks"
. "github.com/topfreegames/pusher/testing"
"github.com/topfreegames/pusher/util"
)

Expand Down Expand Up @@ -143,17 +142,6 @@ var _ = Describe("Kafka Extension", func() {
}))
Expect(consumer.messagesReceived).To(BeEquivalentTo(1000))
})

It("should handle error", func() {
startConsuming()
defer consumer.StopConsuming()
resetError := publishError(kafka.Error{})
defer resetError()
_, ok := <-consumer.stopChannel
Eventually(consumer.run, 5).Should(BeFalse())
Expect(ok).Should(BeFalse())
Expect(hook.Entries).To(ContainLogMessage("Error in Kafka connection."))
})
})

Describe("Configuration Defaults", func() {
Expand Down

0 comments on commit 96bc6c6

Please sign in to comment.