Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): report scheduler readyTarget #642

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

hspedro
Copy link
Collaborator

@hspedro hspedro commented Oct 14, 2024

This metric is useful for creating dynamic graphs, with visual lines representing the readyTarget or targetOccupancy, and also to create budget representations of how much we deviated above and below the target.

New metric name: maestro_next.ready_target

@hspedro hspedro self-assigned this Oct 14, 2024
This metric is useful for creating dynamic graphs, with visual lines
representing the readyTarget or targetOccupancy, and also to create
budget representations of how much we deviated above and below the
target.

New metric name: maestro_next.autoscale.policy.ready_target
@hspedro hspedro force-pushed the feat/report-scheduler-readyTarget branch from cfdab06 to 1928f6b Compare October 14, 2024 13:17
@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.12%. Comparing base (bb118c8) to head (1928f6b).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
internal/core/worker/metricsreporter/metrics.go 0.00% 2 Missing ⚠️
.../worker/metricsreporter/metrics_reporter_worker.go 77.77% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #642       +/-   ##
===========================================
+ Coverage   64.30%   81.12%   +16.82%     
===========================================
  Files          39       85       +46     
  Lines        2905     5887     +2982     
===========================================
+ Hits         1868     4776     +2908     
+ Misses        909      905        -4     
- Partials      128      206       +78     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hspedro hspedro merged commit bde7835 into main Oct 14, 2024
12 checks passed
@hspedro hspedro deleted the feat/report-scheduler-readyTarget branch October 14, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants