-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(disruption): use fixed maxUnavailable #639
Merged
hspedro
merged 2 commits into
topfreegames:main
from
hspedro:refactor/disruption-mitigation
Oct 7, 2024
Merged
refactor(disruption): use fixed maxUnavailable #639
hspedro
merged 2 commits into
topfreegames:main
from
hspedro:refactor/disruption-mitigation
Oct 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hspedro
force-pushed
the
refactor/disruption-mitigation
branch
2 times, most recently
from
September 23, 2024 17:54
9e397c6
to
708829c
Compare
I believe it's better to make this configuration scheduler/game basis. We might end up with different games in the same cluster asking for different configuration values. |
hspedro
force-pushed
the
refactor/disruption-mitigation
branch
16 times, most recently
from
October 4, 2024 18:26
00eb63d
to
c66dd07
Compare
joaobologna
reviewed
Oct 4, 2024
hspedro
force-pushed
the
refactor/disruption-mitigation
branch
from
October 7, 2024 13:01
c66dd07
to
9ba4e15
Compare
joaobologna
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
reinaldooli
reviewed
Oct 7, 2024
reinaldooli
reviewed
Oct 7, 2024
hspedro
force-pushed
the
refactor/disruption-mitigation
branch
3 times, most recently
from
October 7, 2024 13:39
ff8de0c
to
4984596
Compare
Some schedulers might decide on a high readyTarget, which means a low amount of occupied rooms in regards to total rooms, this causes the PDB to have a relative low number in compared to the total. Since PDB does not filter by room status, we still are subject to a high number of rooms being evicted and system highly impacted. To mitigate this, Maestro will now set a fixed amount for maxUnavailable with default value to 5%, if not set on scheduler. It can be configured via: MAESTRO_ADAPTERS_RUNTIME_KUBERNETES_SCHEDULER_MAXUNAVAIALBLE="10%" The variable accepts integets greater than 0 and percentage strings. wip
hspedro
force-pushed
the
refactor/disruption-mitigation
branch
from
October 7, 2024 13:57
4984596
to
9eb93fc
Compare
hspedro
added a commit
that referenced
this pull request
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some schedulers might decide on a high
readyTarget
, which means a low amount of occupied rooms in regards to total rooms, this causes the PDB to have a relatively low number compared to the total. Since PDB does not filter by room status, we are still subject to many rooms being evicted and the system is highly impacted. To mitigate this, Maestro will now set a fixed amount for maxUnavailable with the default value of 5%. It can be configured via:MAESTRO_SERVICES_SCHEDULERMANAGER_DEFAULTPDBMAXUNAVAILABLE="10%"
The variable accepts integers greater than 0 and percentage strings.
Summary of changes
pdbMaxUnavailable
that is a stringScheduler Usage