Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add labels to the maestro scheduler #603

Merged
merged 3 commits into from
Dec 1, 2023

Conversation

reinaldooli
Copy link
Collaborator

What does this PR do?

  • Allow labels to be defined in the scheduler, and then apply those labels to the kubernetes pods created.

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (5164101) 83.03% compared to head (a651e90) 82.99%.

Files Patch % Lines
...nternal/api/handlers/requestadapters/schedulers.go 60.00% 1 Missing and 1 partial ⚠️
.../core/services/schedulers/patch/patch_scheduler.go 33.33% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #603      +/-   ##
==========================================
- Coverage   83.03%   82.99%   -0.04%     
==========================================
  Files          85       85              
  Lines        5583     5594      +11     
==========================================
+ Hits         4636     4643       +7     
- Misses        763      765       +2     
- Partials      184      186       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reinaldooli reinaldooli merged commit 46b7421 into main Dec 1, 2023
6 checks passed
@reinaldooli reinaldooli deleted the feature/kubernetes-labels branch December 1, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants