Parametrize redis pool size configuration (#487)

Parametrize redis pool size configuration

config/config.yaml

@@ -13,6 +13,8 @@ internalApi:
     enabled: true
 
 adapters:
+  redis:
+    poolSize: 500
   schedulerStorage:
     postgres:
       url: "postgres://maestro:maestro@localhost:5432/maestro?sslmode=disable"

internal/service/adapters.go

@@ -75,12 +75,15 @@ const (
 	// Redis instance storage
 	instanceStorageRedisUrlPath      = "adapters.instanceStorage.redis.url"
 	instanceStorageRedisScanSizePath = "adapters.instanceStorage.redis.scanSize"
+	// Redis operation flow
+	operationFlowRedisUrlPath = "adapters.operationFlow.redis.url"
+	// Redis configs
+	redisPoolSize = "adapters.redis.poolSize"
 	// Random port allocator
 	portAllocatorRandomRangePath = "adapters.portAllocator.random.range"
 	// Postgres scheduler storage
 	schedulerStoragePostgresUrlPath = "adapters.schedulerStorage.postgres.url"
-	// Redis operation flow
-	operationFlowRedisUrlPath = "adapters.operationFlow.redis.url"
+
 	// Health Controller operation TTL
 	healthControllerOperationTTL = "workers.redis.operationsTtl"
 )
@@ -121,7 +124,7 @@ func NewRuntimeKubernetes(c config.Config) (ports.Runtime, error) {
 }
 
 func NewOperationStorageRedis(clock ports.Clock, c config.Config) (ports.OperationStorage, error) {
-	client, err := createRedisClient(c.GetString(operationStorageRedisUrlPath))
+	client, err := createRedisClient(c, c.GetString(operationStorageRedisUrlPath))
 	if err != nil {
 		return nil, fmt.Errorf("failed to initialize Redis operation storage: %w", err)
 	}
@@ -134,7 +137,7 @@ func NewOperationStorageRedis(clock ports.Clock, c config.Config) (ports.Operati
 }
 
 func NewOperationLeaseStorageRedis(clock ports.Clock, c config.Config) (ports.OperationLeaseStorage, error) {
-	client, err := createRedisClient(c.GetString(operationLeaseStorageRedisUrlPath))
+	client, err := createRedisClient(c, c.GetString(operationLeaseStorageRedisUrlPath))
 	if err != nil {
 		return nil, fmt.Errorf("failed to initialize Redis operation lease storage: %w", err)
 	}
@@ -143,7 +146,7 @@ func NewOperationLeaseStorageRedis(clock ports.Clock, c config.Config) (ports.Op
 }
 
 func NewRoomStorageRedis(c config.Config) (ports.RoomStorage, error) {
-	client, err := createRedisClient(c.GetString(roomStorageRedisUrlPath))
+	client, err := createRedisClient(c, c.GetString(roomStorageRedisUrlPath))
 	if err != nil {
 		return nil, fmt.Errorf("failed to initialize Redis room storage: %w", err)
 	}
@@ -152,7 +155,7 @@ func NewRoomStorageRedis(c config.Config) (ports.RoomStorage, error) {
 }
 
 func NewGameRoomInstanceStorageRedis(c config.Config) (ports.GameRoomInstanceStorage, error) {
-	client, err := createRedisClient(c.GetString(instanceStorageRedisUrlPath))
+	client, err := createRedisClient(c, c.GetString(instanceStorageRedisUrlPath))
 	if err != nil {
 		return nil, fmt.Errorf("failed to initialize Redis instance storage: %w", err)
 	}
@@ -161,7 +164,7 @@ func NewGameRoomInstanceStorageRedis(c config.Config) (ports.GameRoomInstanceSto
 }
 
 func NewSchedulerCacheRedis(c config.Config) (ports.SchedulerCache, error) {
-	client, err := createRedisClient(c.GetString(schedulerCacheRedisUrlPath))
+	client, err := createRedisClient(c, c.GetString(schedulerCacheRedisUrlPath))
 	if err != nil {
 		return nil, fmt.Errorf("failed to initialize Redis scheduler cache: %w", err)
 	}
@@ -195,12 +198,12 @@ func NewSchedulerStoragePg(c config.Config) (ports.SchedulerStorage, error) {
 	return scheduleradapters.NewSchedulerStorage(opts), nil
 }
 
-func createRedisClient(url string) (*redis.Client, error) {
+func createRedisClient(c config.Config, url string) (*redis.Client, error) {
 	opts, err := redis.ParseURL(url)
 	if err != nil {
 		return nil, fmt.Errorf("invalid redis URL: %w", err)
 	}
-	opts.PoolSize = 500
+	opts.PoolSize = c.GetInt(redisPoolSize)
 	return redis.NewClient(opts), nil
 }
 
@@ -215,7 +218,7 @@ func NewAutoscaler(policies autoscaler.PolicyMap) autoscalerports.Autoscaler {
 }
 
 func NewOperationFlowRedis(c config.Config) (ports.OperationFlow, error) {
-	client, err := createRedisClient(c.GetString(operationFlowRedisUrlPath))
+	client, err := createRedisClient(c, c.GetString(operationFlowRedisUrlPath))
 	if err != nil {
 		return nil, fmt.Errorf("failed to initialize Redis operation storage: %w", err)
 	}

internal/service/adapters_test.go

@@ -65,6 +65,7 @@ func TestOperationStorageRedis(t *testing.T) {
 		config := configmock.NewMockConfig(mockCtrl)
 
 		config.EXPECT().GetString(operationStorageRedisUrlPath).Return(getRedisUrl(t))
+		config.EXPECT().GetInt(redisPoolSize).Return(500)
 		config.EXPECT().GetDuration(healthControllerOperationTTL).Return(time.Minute)
 		opStorage, err := NewOperationStorageRedis(clock, config)
 		require.NoError(t, err)
@@ -81,6 +82,7 @@ func TestOperationStorageRedis(t *testing.T) {
 
 		config.EXPECT().GetString(operationStorageRedisUrlPath).Return("redis://somewhere-in-the-world:6379")
 		config.EXPECT().GetDuration(healthControllerOperationTTL).Return(time.Minute)
+		config.EXPECT().GetInt(redisPoolSize).Return(500)
 		opStorage, err := NewOperationStorageRedis(clock, config)
 		require.NoError(t, err)
 
@@ -110,6 +112,7 @@ func TestRoomStorageRedis(t *testing.T) {
 		config := configmock.NewMockConfig(mockCtrl)
 
 		config.EXPECT().GetString(roomStorageRedisUrlPath).Return(getRedisUrl(t))
+		config.EXPECT().GetInt(redisPoolSize).Return(500)
 		roomStorage, err := NewRoomStorageRedis(config)
 		require.NoError(t, err)
 
@@ -124,6 +127,7 @@ func TestRoomStorageRedis(t *testing.T) {
 		config := configmock.NewMockConfig(mockCtrl)
 
 		config.EXPECT().GetString(roomStorageRedisUrlPath).Return("redis://somewhere-in-the-world:6379")
+		config.EXPECT().GetInt(redisPoolSize).Return(500)
 		roomStorage, err := NewRoomStorageRedis(config)
 		require.NoError(t, err)
 
@@ -154,6 +158,7 @@ func TestInstanceStorageRedis(t *testing.T) {
 
 		config.EXPECT().GetString(instanceStorageRedisUrlPath).Return(getRedisUrl(t))
 		config.EXPECT().GetInt(instanceStorageRedisScanSizePath).Return(10)
+		config.EXPECT().GetInt(redisPoolSize).Return(500)
 		instanceStorage, err := NewGameRoomInstanceStorageRedis(config)
 		require.NoError(t, err)
 
@@ -169,6 +174,7 @@ func TestInstanceStorageRedis(t *testing.T) {
 
 		config.EXPECT().GetString(instanceStorageRedisUrlPath).Return("redis://somewhere-in-the-world:6379")
 		config.EXPECT().GetInt(instanceStorageRedisScanSizePath).Return(10)
+		config.EXPECT().GetInt(redisPoolSize).Return(500)
 		instanceStorage, err := NewGameRoomInstanceStorageRedis(config)
 		require.NoError(t, err)
 
@@ -254,6 +260,7 @@ func TestOperationFlowRedis(t *testing.T) {
 		config := configmock.NewMockConfig(mockCtrl)
 
 		config.EXPECT().GetString(operationFlowRedisUrlPath).Return(getRedisUrl(t))
+		config.EXPECT().GetInt(redisPoolSize).Return(500)
 		operationFlow, err := NewOperationFlowRedis(config)
 		require.NoError(t, err)
 
@@ -268,6 +275,7 @@ func TestOperationFlowRedis(t *testing.T) {
 		config := configmock.NewMockConfig(mockCtrl)
 
 		config.EXPECT().GetString(operationFlowRedisUrlPath).Return("redis://somewhere-in-the-world:6379")
+		config.EXPECT().GetInt(redisPoolSize).Return(500)
 		operationFlow, err := NewOperationFlowRedis(config)
 		require.NoError(t, err)