Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Elixir 1.17/Erlang 27.0 in CI #178

Closed
wants to merge 1 commit into from

Conversation

kianmeng
Copy link
Contributor

@kianmeng kianmeng commented Aug 2, 2024

No description provided.

@kianmeng kianmeng force-pushed the ci-latest-elixir-erlang branch from 7ef5830 to b5240ea Compare August 2, 2024 17:13
@@ -2,7 +2,7 @@
"bunt": {:hex, :bunt, "1.0.0", "081c2c665f086849e6d57900292b3a161727ab40431219529f13c4ddcf3e7a44", [:mix], [], "hexpm", "dc5f86aa08a5f6fa6b8096f0735c4e76d54ae5c9fa2c143e5a1fc7c1cd9bb6b5"},
"cc_precompiler": {:hex, :cc_precompiler, "0.1.9", "e8d3364f310da6ce6463c3dd20cf90ae7bbecbf6c5203b98bf9b48035592649b", [:mix], [{:elixir_make, "~> 0.7", [hex: :elixir_make, repo: "hexpm", optional: false]}], "hexpm", "9dcab3d0f3038621f1601f13539e7a9ee99843862e66ad62827b0c42b2f58a54"},
"connection": {:hex, :connection, "1.1.0", "ff2a49c4b75b6fb3e674bfc5536451607270aac754ffd1bdfe175abe4a6d7a68", [:mix], [], "hexpm", "722c1eb0a418fbe91ba7bd59a47e28008a189d47e37e0e7bb85585a016b2869c"},
"credo": {:hex, :credo, "1.7.3", "05bb11eaf2f2b8db370ecaa6a6bda2ec49b2acd5e0418bc106b73b07128c0436", [:mix], [{:bunt, "~> 0.2.1 or ~> 1.0", [hex: :bunt, repo: "hexpm", optional: false]}, {:file_system, "~> 0.2 or ~> 1.0", [hex: :file_system, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "35ea675a094c934c22fb1dca3696f3c31f2728ae6ef5a53b5d648c11180a4535"},
"credo": {:hex, :credo, "1.7.7", "771445037228f763f9b2afd612b6aa2fd8e28432a95dbbc60d8e03ce71ba4446", [:mix], [{:bunt, "~> 0.2.1 or ~> 1.0", [hex: :bunt, repo: "hexpm", optional: false]}, {:file_system, "~> 0.2 or ~> 1.0", [hex: :file_system, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "8bc87496c9aaacdc3f90f01b7b0582467b69b4bd2441fe8aae3109d843cc2f2e"},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates needed for Credo:

Checking 21 source files ...
Error while running Elixir.Credo.Check.Readability.LargeNumbers on lib/fun_with_flags.ex
Error while running Elixir.Credo.Check.Readability.LargeNumbers on lib/fun_with_flags/flag.ex
Error while running Elixir.Credo.Check.Readability.LargeNumbers on lib/fun_with_flags/application.ex
Error while running Elixir.Credo.Check.Readability.LargeNumbers on lib/fun_with_flags/config.ex
Error while running Elixir.Credo.Check.Readability.MaxLineLength on lib/fun_with_flags/application.ex
Error while running Elixir.Credo.Check.Readability.MaxLineLength on lib/fun_with_flags/config.ex
Error while running Elixir.Credo.Check.Readability.MaxLineLength on lib/fun_with_flags/flag.ex
Error while running Elixir.Credo.Check.Readability.MaxLineLength on lib/fun_with_flags.ex

Error: 17:09:43.219 [error] Task #PID<0.6387.0> started from #PID<0.6313.0> terminating
** (CaseClauseError) no case clause matching: {:ok, 39, 1, [], [{:eol, {38, 4, 1}}, {:end, {38, 1, nil}}, {:eol, {37, 6, 1}}, {:end, {37, 3, nil}}, {:eol, {36, 43, 1}}, {:")", {36, 42, nil}}, {:"(", {36, 41, nil}}, {:paren_identifier, {36, 27, ~c"all_flag_names"}, :all_flag_names}, {:., {36, 26, nil}}, {:")", {36, 25, nil}}, {:"(", {36, 24, nil}}, {:paren_identifier, {36, 5, ~c"persistence_adapter"}, :persistence_adapter}, {:eol, {35, 24, 1}}, {:do, {35, 22, nil}}, {:do_identifier, {35, 7, ~c"all_flag_names"}, :all_flag_names}, {:identifier, {35, 3, ~c"def"}, :def}, {:eol, {34, 60, 1}}, {:"}", {34, 59, nil}}, {:")", {34, 58, nil}}, {:"(", {34, 57, nil}}, {:paren_identifier, {34, 54, ~c"any"}, :any}, {:",", {34, 52, 0}}, {:atom, {34, 46, ~c"error"}, :error}, {:"{", {34, 45, nil}}, {:pipe_op, {34, 43, nil}, :|}, {:"}", {34, 41, nil}}, {:"]", {34, 40, nil}}, {:identifier, {34, 36, ~c"atom"}, :atom}, {:"[", {34, 35, nil}}, {:",", {34, 33, 0}}, {:atom, {34, 30, ~c"ok"}, :ok}, {:"{", {34, 29, nil}}, {:type_op, {34, 26, nil}, :"::"}, {:")", {34, 24, nil}}, {:"(", {34, 23, nil}}, {:paren_identifier, {34, 9, ~c"all_flag_names"}, :all_flag_names}, {:identifier, {34, 4, ~c"spec"}, :spec}, {:at_op, {34, 3, nil}, :@}, {:eol, {32, 6, 2}}, {:end, {32, 3, nil}}, {:eol, {31, 38, ...}}, {:")", {31, ...}}, {:"(", {...}}, {:paren_identifier, ...}, {...}, ...], []}
** (EXIT from #PID<0.95.0>) an exception was raised:

@tompave
Copy link
Owner

tompave commented Aug 6, 2024

Hi, thank you for the contribution!
And apologies, but yesterday I started catching up with some long overdue maintenance on this project, and the first thing I did was updating the CI setup. I did that in #179, before seeing your PR.

This is now already done, therefore I'll close it.

@tompave tompave closed this Aug 6, 2024
@kianmeng
Copy link
Contributor Author

kianmeng commented Aug 7, 2024

Hi, thank you for the contribution! And apologies, but yesterday I started catching up with some long overdue maintenance on this project, and the first thing I did was updating the CI setup. I did that in #179, before seeing your PR.

This is now already done, therefore I'll close it.

Noted, and thanks for this library and keeping it up-to-date!

I noticed there is a V2 branch, https://github.com/tompave/fun_with_flags/tree/v2, are we going to see a V2 release in foreseeable future?

@tompave
Copy link
Owner

tompave commented Aug 7, 2024

Thank you for the kind words.

I noticed there is a V2 branch, https://github.com/tompave/fun_with_flags/tree/v2, are we going to see a V2 release in foreseeable future?

I've been working on it on and off, but I have no clear timeline in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants