INT-3324: move tinymce to be an optional peer dependency #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danoaky-tiny
changed the title
danoaky-tiny
requested review from
spocke,
TheSpyder,
ltrouton,
jscasca,
ArvinJ-H,
hamza0867,
MitchC1999,
kemister85,
tiny-ben-tran,
shanmen-tiny and
FarzadHayat
and removed request for
a team
kemister85
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
LGTM
Mention this in-case this is something we need to support:
warning "@storybook/vue3 > vue-docgen-loader > [email protected]" has unmet peer dependency "@babel/preset-env@^7.1.6". warning " > [email protected]" has incorrect peer dependency "rollup@>=0.66.0 <2".
MitchC1999
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INT-3324
Changes:
tinymcepackage is now an optional peer dependency.tinymcenow useimport type ...to help prevent accidental usage of tinymce JS code through a direct import in this way.