*: revert name #25
Merged
*: revert name #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jay Lee <[email protected]>
Signed-off-by: Jay Lee <[email protected]>
Signed-off-by: Jay Lee <[email protected]>
sticnarf
reviewed
Apr 29, 2022
| - run: cargo clippy -p tikv-jemallocator -- -D clippy::all | ||
| - run: cargo clippy -p tikv-jemallocator-global -- -D clippy::all | ||
| - run: cargo clippy -p tikv-jemalloc-ctl -- -D clippy::all | ||
| - run: cargo clippy -p jemalloc-sys -- -D clippy::all |
There was a problem hiding this comment.
Does it work on the tikv-main branch?
There was a problem hiding this comment.
No, but tikv-main branch will use the old workflows.
README.md
Outdated
| @@ -1,42 +1,44 @@ | |||
| # tikv-jemallocator | |||
| # jemallocator | |||
|
|
|||
| [![ci]][github actions] [![Latest Version]][crates.io] [![docs]][docs.rs] | |||
|
|
|||
| This project is a simplified fork of [jemallocator](https://github.com/gnzlbg/jemallocator) focus on server. | |||
There was a problem hiding this comment.
As this repo will be the successor of gnzlbg/jemallocator, I think we should change this sentence to clarify the status of this repo.
README.md
Outdated
|
|
||
| [![ci]][github actions] [![Latest Version]][crates.io] [![docs]][docs.rs] | ||
|
|
||
| This project is a simplified fork of [jemallocator](https://github.com/gnzlbg/jemallocator) focus on server. | ||
|
|
||
| The difference between `tikv-jemallocator` and `jemallocator` is only name. The source is the same. |
There was a problem hiding this comment.
Better to explain the reason why both crates exist, for example:
Suggested change
| The difference between `tikv-jemallocator` and `jemallocator` is only name. The source is the same. | |
| The difference between `tikv-jemallocator` and `jemallocator` is only name. The same source is published as two different crates, so projects using either crate will get updates. |
Signed-off-by: Jay Lee <[email protected]>
emixa-d
added a commit
to emixa-d/antioxidant-fallback
that referenced
this pull request
Jun 29, 2022
… package. It bundles jemalloc: <https://issues.guix.gnu.org/56157>. And apparently jemalloc-sys has become tikv-jemalloc-sys: <tikv/jemallocator#25>. - add replacement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in gnzlbg#173, I will also publish this crate in the name of
jemallocator. Because tikv-jemallocator is already used by several projects, to make less disturbing to dependents, two crates will be published at the same time with only name differences.The tikv-xxx versions are maintained in the branch tikv-main.