UnitTests and Coverage reporting #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joenpera
force-pushed
the
unittest_impl
branch
5 times, most recently
from
9e568c2 to
cd61f0a
Compare
4966 - Comms Service Discovery 4967 - Comms Settings 4968 - Comms Status Jira-Id: SECO-4966, SECO-4967, SECO-4968 Signed-off-by: Mika Joenpera <[email protected]>
Develop to working branch
Jira-Id: SECO-4967, SECO-4961 Signed-off-by: Mika Joenpera <[email protected]>
pentestiing
suggested changes
May 13, 2024
modules/sc-mesh-secure-deployment/src/nats/src/comms_command.py
Outdated
Show resolved
Hide resolved
modules/sc-mesh-secure-deployment/src/nats/tests/test_settings.py
Outdated
Show resolved
Hide resolved
- Commented code delete (comms_command.py) - try/except removal and [] index checks added (comms_settings.py) Jira-Id: SECO-4966 Signed-off-by: Mika Joenpera <[email protected]>
Jira-Id: SECO-4966 Signed-off-by: Mika Joenpera <[email protected]>
saauvine
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira-Id: SECO-4966