Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to choose VM for start app #9

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

avnik
Copy link
Contributor

@avnik avnik commented Aug 21, 2024

Description

Add ability to specify VM to run application (by @mbssrc suggestion)
Also adjust tests to recent changes in main branch

Checklist

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Test procedure added to nixos/tests
  • Author has run nix flake check --accept-flake-config and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing

@avnik avnik changed the title Avnik/rust proto take 2 Add support to choose VM for start app Aug 21, 2024
@mbssrc
Copy link
Collaborator

mbssrc commented Aug 22, 2024

As this is a quickfix, let's get this merged now, while you are re-coding the request parameters.
Fixed version here: eacbac0 , please double check

@mbssrc mbssrc merged commit 418eaa4 into tiiuae:main Aug 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants